Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily remove "cpu" package testing from test-suite github->action #737

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Temporarily remove "cpu" package testing from test-suite github->action #737

merged 1 commit into from
Dec 13, 2023

Conversation

tdrozdovsky
Copy link
Contributor

Description

Probably the server uses a new type of processor, so this test does not work correctly. Deeper study of the issue is required

Type of change

  • CI system update
  • Test Coverage update

Test Configuration:

  • OS type & version: Ubuntu 20.04
  • Hardware: x86-64 (e.g., x86, x86-64, arm, arm64)
  • Toolchain: Docker v20.10 & Go v1.19
  • Edge Orchestration Release: v1.1.x

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tdrozdovsky tdrozdovsky self-assigned this Dec 13, 2023
@boring-cyborg boring-cyborg bot added the CI label Dec 13, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

MoonkiHong
MoonkiHong approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

tiokim
tiokim approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiokim tiokim merged commit b6f35b2 into lf-edge:master Dec 13, 2023
15 checks passed
@tdrozdovsky tdrozdovsky deleted the exclude-cpu-test branch May 3, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonkiHong MoonkiHong MoonkiHong approved these changes

@tiokim tiokim tiokim approved these changes

@suresh-lc suresh-lc Awaiting requested review from suresh-lc

Assignees

@tdrozdovsky tdrozdovsky

Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdrozdovsky @tiokim @MoonkiHong