Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support decode schemaless json #2500

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 20, 2023

No description provided.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (60b3ab9) 62.79% compared to head (65ad1f0) 62.84%.

Files Patch % Lines
internal/converter/json/converter.go 62.95% 70 Missing and 23 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
+ Coverage   62.79%   62.84%   +0.05%     
==========================================
  Files         308      308              
  Lines       36833    36839       +6     
==========================================
+ Hits        23126    23150      +24     
+ Misses      11583    11561      -22     
- Partials     2124     2128       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer force-pushed the support_schemaless_decode_2 branch 2 times, most recently from e1dfc53 to 6fdecbc Compare December 20, 2023 08:31
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer force-pushed the support_schemaless_decode_2 branch from 01f72a0 to fb0ca6e Compare December 25, 2023 08:04
@Yisaer Yisaer marked this pull request as ready for review December 29, 2023 02:36
@Yisaer Yisaer requested a review from ngjaying December 29, 2023 02:36
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer force-pushed the support_schemaless_decode_2 branch from ee3d96a to 65ad1f0 Compare December 29, 2023 03:55
@ngjaying ngjaying merged commit 26c90fb into lf-edge:master Dec 29, 2023
55 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants