Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sync cache metrics #3510

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 15, 2025

No description provided.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying January 15, 2025 05:07
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-1.14@b9b5af5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
metrics/sync_cache.go 0.00% 3 Missing ⚠️
internal/server/promMetrics/metrcis.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             master-1.14    #3510   +/-   ##
==============================================
  Coverage               ?   63.34%           
==============================================
  Files                  ?      355           
  Lines                  ?    40808           
  Branches               ?        0           
==============================================
  Hits                   ?    25847           
  Misses                 ?    12706           
  Partials               ?     2255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit 6c7f5ce into lf-edge:master-1.14 Jan 15, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants