memory-monitor: disable by default.

The memory monitor is a new component with limited real-world testing.
To ensure system stability, it is now disabled by default. Users can
enable it manually if needed.

This commit updates the default value of `memory-monitor.enabled` to
`false` in the global config and documentation, reflecting the change in
behavior.

Signed-off-by: Nikolay Martyanov <[email protected]>

docs/CONFIG-PROPERTIES.md

@@ -67,7 +67,7 @@
 | goroutine.leak.detection.keep.stats.hours | integer (hours) | 24 | Amount of hours to keep the stats for leak detection. We keep more stats than the check window to be able to react to settings with a bigger check window via configuration. |
 | goroutine.leak.detection.cooldown.minutes | integer (minutes) | 5 | Cooldown period in minutes after the leak detection is triggered. During this period, no stack traces are collected; only warning messages are logged. |
 | kubevirt.drain.timeout | integer | 24 | hours to allow kubernetes to drain a node |
-| memory-monitor.enabled | boolean | true | Enable external memory monitoring and memory pressure events handling |
+| memory-monitor.enabled | boolean | false | Enable external memory monitoring and memory pressure events handling |
 
 ## Log levels
 

pkg/memory-monitor/README.md

@@ -190,6 +190,10 @@ This setup allows you to toggle memory monitoring on and off, which can be
 especially useful if you suspect that the memory monitor's handler script might
 be consuming excessive CPU or memory resources.
 
+As the memory monitor is a new component in the EVE system, and very few
+real-world testing was done with it, is important to be on the safe side, so we
+disable the memory monitor by default. It can be enabled by the user if needed.
+
 ## Internals of the build and startup process
 
 To deploy the memory monitor to the EVE system, we create a corresponding

pkg/pillar/types/global.go

@@ -1005,7 +1005,7 @@ func NewConfigItemSpecMap() ConfigItemSpecMap {
 	configItemSpecMap.AddBoolItem(EnableARPSnoop, true)
 	configItemSpecMap.AddBoolItem(WwanQueryVisibleProviders, false)
 	configItemSpecMap.AddBoolItem(NetworkLocalLegacyMACAddress, false)
-	configItemSpecMap.AddBoolItem(MemoryMonitorEnabled, true)
+	configItemSpecMap.AddBoolItem(MemoryMonitorEnabled, false)
 
 	// Add TriState Items
 	configItemSpecMap.AddTriStateItem(NetworkFallbackAnyEth, TS_DISABLED)