[12.0-stable] stat st_blocks block size read from DEV_BSIZE #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From POSIX standard: Traditionally, some implementations defined the multiplier for st_blocks in <sys/param.h> as the symbol DEV_BSIZE. Don't use stat.Blksize which can return 4k and overinflate sizes. Added pillar gotest TestStatAllocatedBytes Signed-off-by: Andrew Durbin <[email protected]> (cherry picked from commit 56a26d9)
OhmSpectator
changed the title
OhmSpectator
approved these changes
Feb 10, 2025
|
This backport seems to be having issues with the C import, looking into it. |
"Go moves in a mysterious way" (с) |
|
Actually, the errors I noticed on the PR build were related to the pull limits again, so I have restarted the tests. |
|
The virtualization test fails in TestVcomLinkTpmRequestEK but vcom is not present in 12.0-stable. @uncleDecart @shjala do we need to create a separate version of Eden for 12.0-stable? |
I think so, I'll sync with Pavel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From POSIX standard:
Traditionally, some implementations defined
the multiplier for st_blocks in <sys/param.h>
as the symbol DEV_BSIZE.
Don't use stat.Blksize which can return 4k
and overinflate sizes.
Added pillar gotest TestStatAllocatedBytes
Signed-off-by: Andrew Durbin [email protected]
(cherry picked from commit 56a26d9)
Backport of #4596