Fix update_kernel_commits.py to keep '-' in platform names #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rene I have a fix but I have not tested it on real commits/branches |
rucoder
force-pushed
the
rucoder/kernel-update-script
branch
from
065da23 to
4c77bf0
Compare
|
@rene pleease take a look. Tested on current branches and I've added a couple of unit tests as well |
rucoder
force-pushed
the
rucoder/kernel-update-script
branch
2 times, most recently
from
9c6470b to
dcc3dbd
Compare
OhmSpectator
requested changes
Feb 14, 2025
After nvidia platforms were introduced the logic to generate variables from branches is broken because of e.g. 'nvidia-jp6' Signed-off-by: Mikhail Malyshev <[email protected]>
rucoder
force-pushed
the
rucoder/kernel-update-script
branch
from
dcc3dbd to
13fc5dd
Compare
rene
approved these changes
Feb 14, 2025
OhmSpectator
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After nvidia platforms were introduced the logic to generate variables from branches is broken because of e.g. 'nvidia-jp6'