Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various missing PR fixes for kubevirt startup. #4617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Various missing PR fixes for kubevirt startup. #4617

wants to merge 1 commit into from
+713 −479

Conversation

andrewd-zededa
Copy link
Contributor

  • Incorrect longhorn yaml 1.6.2->1.6.3 to match LONGHORN_VERSION
  • Incorrect type passed to NodeDrainStatus publish.
  • ignore yamllint issues in longhorn project supplied yaml

@andrewd-zededa
Various missing PR fixes for kubevirt startup.
99da8b5 
- Incorrect longhorn yaml 1.6.2->1.6.3 to match LONGHORN_VERSION
- Incorrect type passed to NodeDrainStatus publish.
- ignore yamllint issues in longhorn project supplied yaml

Signed-off-by: Andrew Durbin <[email protected]>
eriknordmark
eriknordmark approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we didn't detect the pointer type in the calls to Publish in testing? It should have caused a log.Fatal when the Publish is called.

@OhmSpectator
Copy link
Member

How come we didn't detect the pointer type in the calls to Publish in testing? It should have caused a log.Fatal when the Publish is called.

I think there is no any test, running this code.

@andrewd-zededa
Copy link
Contributor Author

@eriknordmark @OhmSpectator Correct the only CI runs for kubevirt currently I believe is an amd64 build, no tests.

We certainly need to improve on this front, do we have runner space for an eden kubevirt "just boot" test?

@OhmSpectator
Copy link
Member

We certainly need to improve on this front, do we have runner space for an eden kubevirt "just boot" test?

@uncleDecart, what do you think here? Are our runners powerful enough? )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

@zedi-pramodh zedi-pramodh Awaiting requested review from zedi-pramodh zedi-pramodh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewd-zededa @OhmSpectator @eriknordmark