-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation for upcoming VSCode extension release #288
Conversation
Tried it locally, it's blurry but not that terrible if we use the same size/ppi: You can use a bigger-sized PNG: Or you can use this plugin which we enabled for our site, then inline the image. The documentation is garbage though. import Image from '@theme/IdealImage';
{/* stuff in the middle */}
import local_libraries from '../assets/images/vs_code/local_libraries.png';
<Image img={local_libraries} style={{maxWidth: 400}} /> The reason inline SVG looks better is that it inlines the style and additional metadata in the SVG, and stored a bigger PNG. |
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: Marten Lohstroh <[email protected]>
Got it, thanks! I’ll use this plugin with PNGs instead of SVGs |
To-Do
|
Just a reminder, after you finish it would be nice to clean up the commits a little bit by squashing some of them |
Co-authored-by: Marten Lohstroh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're almost there. I added some more feedback and tried to give a more useful definition of "project."
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: Marten Lohstroh <[email protected]>
Co-authored-by: Marten Lohstroh <[email protected]>
This PR aims to update the VSCode extension documentation to reflect the recent changes made to the extension (see this PR).