Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in the Lingua Franca Language Server to support improvements in the VSCode extension #2370

Merged
merged 18 commits into from
Aug 29, 2024

Conversation

vinzbarbuto
Copy link
Collaborator

This code includes the extensions made to the Lingua Franca Language Server to support the latest improvements for the VSCode extension, specifically those related to the Lingua Franca Package Explorer.

@vinzbarbuto vinzbarbuto added the enhancement Enhancement of existing feature label Jul 16, 2024
@lhstrh
Copy link
Member

lhstrh commented Jul 16, 2024

Also in this branch, conflicts remain.

Copy link
Collaborator

@soerendomroes soerendomroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one could rename the Tree classes to something more speaking since this is a very specific tree, but otherwise it looks good to me.

@vinzbarbuto
Copy link
Collaborator Author

vinzbarbuto commented Jul 18, 2024

Maybe one could rename the Tree classes to something more speaking since this is a very specific tree, but otherwise it looks good to me.

@soerendomroes Perhaps I can rename it as LibraryFileTree while nodes can be LibraryFileTreeNode instead of TreeNode

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks close. Some suggestions included. We should merge with master and convert to a regular PR rather than a draft.

@vinzbarbuto

This comment was marked as outdated.

vinzbarbuto and others added 2 commits August 19, 2024 17:58
…Node.java` to `ReactorNode.java` to better reflect their functionality; Improved documentation across the renamed files for clarity.
@vinzbarbuto vinzbarbuto marked this pull request as ready for review August 23, 2024 16:42
@lhstrh lhstrh requested a review from edwardalee August 29, 2024 17:52
@lhstrh lhstrh changed the title Extend the Lingua Franca Language Server to support improvements in the VSCode extension Extension of the Lingua Franca Language Server to support improvements in the VSCode extension Aug 29, 2024
@lhstrh lhstrh changed the title Extension of the Lingua Franca Language Server to support improvements in the VSCode extension Changes in the Lingua Franca Language Server to support improvements in the VSCode extension Aug 29, 2024
@lhstrh lhstrh enabled auto-merge August 29, 2024 17:57
@lhstrh lhstrh dismissed edwardalee’s stale review August 29, 2024 18:57

Requested changes have been addressed.

@lhstrh lhstrh added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@lhstrh lhstrh added this pull request to the merge queue Aug 29, 2024
Merged via the queue into master with commit 4f69124 Aug 29, 2024
41 checks passed
@lhstrh lhstrh deleted the extending branch August 29, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants