-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in the Lingua Franca Language Server to support improvements in the VSCode extension #2370
Conversation
…-file and import-selected-reactor commands
Also in this branch, conflicts remain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one could rename the Tree
classes to something more speaking since this is a very specific tree, but otherwise it looks good to me.
@soerendomroes Perhaps I can rename it as |
…aryFileTreeNode; Fix formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks close. Some suggestions included. We should merge with master and convert to a regular PR rather than a draft.
lsp/src/main/java/org/lflang/diagram/lsp/LFLanguageServerExtension.java
Outdated
Show resolved
Hide resolved
lsp/src/main/java/org/lflang/diagram/lsp/LFLanguageServerExtension.java
Outdated
Show resolved
Hide resolved
lsp/src/main/java/org/lflang/diagram/lsp/LibraryFileTreeNode.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Edward A. Lee <[email protected]>
Co-authored-by: Edward A. Lee <[email protected]>
Co-authored-by: Edward A. Lee <[email protected]>
Co-authored-by: Edward A. Lee <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
…Node.java` to `ReactorNode.java` to better reflect their functionality; Improved documentation across the renamed files for clarity.
Requested changes have been addressed.
This code includes the extensions made to the Lingua Franca Language Server to support the latest improvements for the VSCode extension, specifically those related to the Lingua Franca Package Explorer.