Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reactions to test #2412

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Added reactions to test #2412

merged 3 commits into from
Sep 29, 2024

Conversation

edwardalee
Copy link
Collaborator

A test newly added in merged #2409 had no reactions. Apparently, on Windows only, this results in running forever. I have opened an issue in reactor-c and propose updating the test here to add reactions.

@edwardalee edwardalee added c Related to C target windows Related to the Microsoft Windows platform bugfix labels Sep 29, 2024
@edwardalee edwardalee requested a review from erlingrj September 29, 2024 16:31
@lhstrh lhstrh added exclude Exclude from change log and removed bugfix labels Sep 29, 2024
@lhstrh
Copy link
Member

lhstrh commented Sep 29, 2024

Note: changed the labels because this isn't a bugfix but a workaround.

@lhstrh lhstrh merged commit 1ad92a1 into master Sep 29, 2024
23 of 24 checks passed
@lhstrh lhstrh deleted the add-reaction branch September 29, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Related to C target exclude Exclude from change log windows Related to the Microsoft Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants