-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduling enclaves #242
Scheduling enclaves #242
Conversation
… cater to arduino_cli whihc has to compile every source file in the project
@edwardalee and @lhstrh. I am tagging you for a review now. There is still a test failure on macOS on a test with coordinated shutdown of enclaves. I will look at this when I get my hands on a MacBook next week |
The compiler errors now are due the fact that in reactor-c the preprocessor flags for picking the scheduler has changed, from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a review of rti_local.h/c. I don't understand the locking strategy here.
I have started doing this in |
Co-authored-by: Edward A. Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finally gone through this whole PR and it looks good to me! Modulo small comments, I think we can merge this as soon as we can get tests to pass in lingua-franca/master with minimal changes to lingua-franca. This will not yet provide support for enclaves, but will get us much closer.
I'm proposing further changes in the enclaves3 branch, but we can review and merge those after merging this into main.
Co-authored-by: Edward A. Lee <[email protected]>
@edwardalee. I have addressed all comments. I removed the PROLOGUE/EPILOGUE macros which locked/unlocked mutex. I have made the documentation clearer with respect to which mutex are assumed held etc. Tests are passing here and in LF? Shall we merge? |
This PR implements the first version of scheduling enclaves in the C target. This PR is paired with lf-lang/lingua-franca#1872.
Things not supported yet: