-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new directory under federated
named network
#292
Conversation
@lhstrh This was discussed in the security meeting. The point is just moving network related c and header files under a directory |
fb53d12
to
e19d12a
Compare
I would call |
Looks like a reasonable approach. Just one question about the new CMakeLists.txt |
Fixed all to |
a53ad1e
to
f42708b
Compare
federated
named networks
.federated
named networks
.
… network-structure
@lhstrh Can I merge this together with lf-lang/lingua-franca#2070? |
I noticed that not all test in lf-lang/lingua-franca#2070 are passing though... |
federated
named networks
.federated
named network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo comment.
@lhstrh Oops. Sorry for that. I thought it was finished. The |
I think it's OK to just go ahead and merge once the tests pass. |
As long as you are using reactor-c/main it is OK to merge this. |
This PR is the first step abstracting the network layer which is in #281.
This changes the file structure of the reactor-c, adding a new directory under
federated
namednetworks
.Currently only moved
net_util.c
net_common.h
andnet_util.h
under newly named directorynetworks
.This is to add more files in future such as
net_tls.c
.The corresponding
CMakelists.txt
files have been modified together.The idea comes from how the
platform
works. Each platform related header such aslf_arduino_support.h
lf_rp2040_support.h
is inside the directoryplatform
.This must be merged together with lf-lang/lingua-franca#2070