Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refont of idendity card on my identities page #1007

Open
wants to merge 22 commits into
base: testnet
Choose a base branch
from
+22,148 −187
Open

Refont of idendity card on my identities page #1007

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2452e51
created my branch and ready to begin
Prosper1218 Jan 27, 2025
f87aa5c
removed the back button and made sure the id doesn't move when the vi…
Prosper1218 Jan 28, 2025
25a8db9
Merge branch 'testnet' of https://github.com/Prosper1218/app.starknet…
Prosper1218 Jan 28, 2025
ade753f
edited the my identities page, ID does not move when the view more bu…
Prosper1218 Jan 28, 2025
e4d83e2
removed the back button on the ideantity details page and fixed the l…
Prosper1218 Jan 29, 2025
a2c16c0
Fixed mid screen responsiveness, removed back button when an id is cl…
sylvester-strk Jan 30, 2025
771155b
fixed icon issues, fixed mid screen responsiveness issues, added whit…
sylvester-strk Jan 30, 2025
f7926f1
made changes to the icon.
Prosper1218 Jan 30, 2025
6444fe6
removed scrollbar, fixed identities container width and padding and a…
Prosper1218 Jan 31, 2025
46c72ad
fixed identity container margin on small screens and fixed seperator …
Prosper1218 Jan 31, 2025
d721000
fixed the padding top on first child of the identities container...
Prosper1218 Jan 31, 2025
385fddc
fixed margin on xl screens.
Prosper1218 Jan 31, 2025
ca44f48
restructured identity page.
Prosper1218 Jan 31, 2025
2270ab8
ref: cleaning the code
Marchand-Nicolas Feb 1, 2025
861d621
ref: cleaning the code
Marchand-Nicolas Feb 1, 2025
5050376
ref: remove class param
Marchand-Nicolas Feb 1, 2025
f30e4c2
fixed hideActions state issue
Prosper1218 Feb 1, 2025
20edc3e
Merge branch 'fix-945' of https://github.com/Prosper1218/app.starknet…
Prosper1218 Feb 1, 2025
88b3eff
reformatting
Marchand-Nicolas Feb 1, 2025
aa9e5a0
cleaned up..
Prosper1218 Feb 1, 2025
7e1b5b5
Merge branch 'fix-945' of https://github.com/Prosper1218/app.starknet…
Prosper1218 Feb 1, 2025
d38896c
reformat
Marchand-Nicolas Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
NEXT_PUBLIC_SERVER_LINK=https://api.starknet.id
Prosper1218 marked this conversation as resolved.
Show resolved Hide resolved
NEXT_PUBLIC_STARKNET_ID=https://starknet.id
NEXT_PUBLIC_IDENTITY_CONTRACT=0x05dbdedc203e92749e2e746e2d40a768d966bd243df04a6b712e222bc040a9af
NEXT_PUBLIC_STARKNETID_CONTRACT=0x05dbdedc203e92749e2e746e2d40a768d966bd243df04a6b712e222bc040a9af
NEXT_PUBLIC_NAMING_CONTRACT=0x6ac597f8116f886fa1c97a23fa4e08299975ecaf6b598873ca6792b9bbfb678
NEXT_PUBLIC_PRICING_CONTRACT=0x035F2ca59fE00Ef8968B98EA4b79de0e82a8daC4CBc0f48E93F3dE90e65Ae568
NEXT_PUBLIC_VERIFIER_CONTRACT=0x07d14dfd8ee95b41fce179170d88ba1f0d5a512e13aeb232f19cfeec0a88f8bf
NEXT_PUBLIC_DEPRECATED_VERIFIER_CONTRACT=0x019e5204152a72891bf8cd0bed8f03593fdb29ceacd14fca587be5d9fcf87c0e
NEXT_PUBLIC_OLD_VERIFIER_CONTRACT=0x4d546c8d60cfd591557ac0613be5ceeb0ea6f797e7d11c0b5160d145fa3089f
NEXT_PUBLIC_VERIFIER_POP_CONTRACT=0x0293eb2ba9862f762bd3036586d5755a782bd22e6f5028320f1d0405fd47bff4
NEXT_PUBLIC_ETHER_CONTRACT=0x049d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7
NEXT_PUBLIC_L1BUYING_CONTRACT=0x2a8f4E6A844A7cAa602E77B45651635e81EeF0ce
NEXT_PUBLIC_VERIFIER_LINK=https://verifier.starknet.id
NEXT_PUBLIC_IS_TESTNET=false
NEXT_PUBLIC_TRIBE_CONTRACT=0x021b4b01282f11c7847007c7f064e20413c66f3e71f2c36b4cacaaf2a244dca6
NEXT_PUBLIC_NFT_PP_VERIFIER=0x070aaa20ec4a46da57c932d9fd89ca5e6bb9ca3188d3df361a32306aff7d59c7
NEXT_PUBLIC_RPC_URL=https://rpc.starknet.id
NEXT_PUBLIC_MULTICALL_CONTRACT=0x034ffb8f4452df7a613a0210824d6414dbadcddce6c6e19bf4ddc9e22ce5f970
NEXT_PUBLIC_DOMAIN_GIFT_CONTRACT=0x040803720a1723355f652e1b3609275f561541e65ebffdf87e4075f9181df452
NEXT_PUBLIC_AVNU_API=https://starknet.impulse.avnu.fi/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancel all these changes to the env example

# NEXT_PUBLIC_SERVER_LINK=https://api.starknet.id
# NEXT_PUBLIC_STARKNET_ID=https://starknet.id
# NEXT_PUBLIC_IDENTITY_CONTRACT=0x05dbdedc203e92749e2e746e2d40a768d966bd243df04a6b712e222bc040a9af
# NEXT_PUBLIC_STARKNETID_CONTRACT=0x05dbdedc203e92749e2e746e2d40a768d966bd243df04a6b712e222bc040a9af
# NEXT_PUBLIC_NAMING_CONTRACT=0x6ac597f8116f886fa1c97a23fa4e08299975ecaf6b598873ca6792b9bbfb678
# NEXT_PUBLIC_PRICING_CONTRACT=0x035F2ca59fE00Ef8968B98EA4b79de0e82a8daC4CBc0f48E93F3dE90e65Ae568
# NEXT_PUBLIC_VERIFIER_CONTRACT=0x07d14dfd8ee95b41fce179170d88ba1f0d5a512e13aeb232f19cfeec0a88f8bf
# NEXT_PUBLIC_DEPRECATED_VERIFIER_CONTRACT=0x019e5204152a72891bf8cd0bed8f03593fdb29ceacd14fca587be5d9fcf87c0e
# NEXT_PUBLIC_OLD_VERIFIER_CONTRACT=0x4d546c8d60cfd591557ac0613be5ceeb0ea6f797e7d11c0b5160d145fa3089f
# NEXT_PUBLIC_VERIFIER_POP_CONTRACT=0x0293eb2ba9862f762bd3036586d5755a782bd22e6f5028320f1d0405fd47bff4
# NEXT_PUBLIC_ETHER_CONTRACT=0x049d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7
# NEXT_PUBLIC_L1BUYING_CONTRACT=0x2a8f4E6A844A7cAa602E77B45651635e81EeF0ce
# NEXT_PUBLIC_VERIFIER_LINK=https://verifier.starknet.id
# NEXT_PUBLIC_IS_TESTNET=false
# NEXT_PUBLIC_TRIBE_CONTRACT=0x021b4b01282f11c7847007c7f064e20413c66f3e71f2c36b4cacaaf2a244dca6
# NEXT_PUBLIC_NFT_PP_VERIFIER=0x070aaa20ec4a46da57c932d9fd89ca5e6bb9ca3188d3df361a32306aff7d59c7
# NEXT_PUBLIC_RPC_URL=https://rpc.starknet.id
# NEXT_PUBLIC_MULTICALL_CONTRACT=0x034ffb8f4452df7a613a0210824d6414dbadcddce6c6e19bf4ddc9e22ce5f970
# NEXT_PUBLIC_DOMAIN_GIFT_CONTRACT=0x040803720a1723355f652e1b3609275f561541e65ebffdf87e4075f9181df452




2 changes: 1 addition & 1 deletion .env.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ NEXT_PUBLIC_DEPRECATED_VERIFIER_CONTRACT=0x019e5204152a72891bf8cd0bed8f03593fdb2
NEXT_PUBLIC_OLD_VERIFIER_CONTRACT=0x4d546c8d60cfd591557ac0613be5ceeb0ea6f797e7d11c0b5160d145fa3089f
NEXT_PUBLIC_VERIFIER_POP_CONTRACT=0x03528caf090179e337931ee669a5b0214041e1bae30d460ff07d2cea2c7a9106
NEXT_PUBLIC_RPC_URL=https://sepolia.rpc.starknet.id/
NEXT_PUBLIC_STARKNET_ID=https://app.starknet.id
NEXT_PUBLIC_STARKNET_ID=https://app.starknet.id
19 changes: 6 additions & 13 deletions components/UI/iconsComponents/icons/renewalIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,12 @@ import React, { FunctionComponent } from "react";

const RenewalIcon: FunctionComponent<IconProps> = ({ color, width }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove unused props or implement their functionality.

The component accepts color and width props but doesn't utilize them. Either remove these unused props or implement their functionality to make the icon customizable.

-const RenewalIcon: FunctionComponent<IconProps> = ({ color, width }) => {
+const RenewalIcon: FunctionComponent = () => {

Or implement the props:

 const RenewalIcon: FunctionComponent<IconProps> = ({ color, width }) => {
   return (
-    <svg width="21" height="20" viewBox="0 0 21 20" fill="none" xmlns="http://www.w3.org/2000/svg">
+    <svg width={width || "21"} height={width ? width * (20/21) : "20"} viewBox="0 0 21 20" fill="none" xmlns="http://www.w3.org/2000/svg">

Committable suggestion skipped: line range outside the PR's diff.

return (
<svg
xmlns="http://www.w3.org/2000/svg"
width={width}
height={width}
viewBox="0 0 13 13"
fill="none"
>
<path
fillRule="evenodd"
clipRule="evenodd"
d="M11.2899 4.84719C10.1284 2.79743 7.6404 -0.0753518 3.51484 2.94169L4.46689 3.57686C4.62557 3.68272 4.84771 3.95796 4.46689 4.21203C4.08607 4.4661 2.19254 5.27064 1.29338 5.64116C1.02892 5.79995 0.500006 5.95874 0.500006 5.32357V1.67136C0.500006 1.40671 0.626947 0.94092 1.13471 1.19499C1.64247 1.44905 2.19254 1.93601 2.40411 2.14774C3.51484 0.877403 7.52205 -0.851837 10.1792 1.19499C12.3419 2.86088 12.4983 4.55619 12.4983 4.78793C12.4983 6.05964 11.5978 5.39053 11.2899 4.84719ZM1.70837 8.15273C2.86995 10.2025 5.3579 13.0753 9.48346 10.0582L8.53141 9.42306C8.37274 9.3172 8.15059 9.04196 8.53141 8.78789C8.91223 8.53382 10.8058 7.72928 11.7049 7.35877C11.9694 7.19997 12.4983 7.04118 12.4983 7.67635V11.3286C12.4983 11.5932 12.3714 12.059 11.8636 11.8049C11.3558 11.5509 10.8058 11.0639 10.5942 10.8522C9.48346 12.1225 5.47625 13.8518 2.8191 11.8049C0.65645 10.139 0.5 8.44373 0.5 8.21199C0.5 6.94028 1.40046 7.60939 1.70837 8.15273Z"
fill={color}
/>
<svg width="21" height="20" viewBox="0 0 21 20" fill="none" xmlns="http://www.w3.org/2000/svg">
<ellipse cx="17.137" cy="15.0669" rx="2.57449" ry="2.33056" fill="#0C8654"/>
<path d="M19.7089 6.00473V6.28565C19.7089 6.62899 19.3034 6.90991 18.8078 6.90991H2.58857C2.09298 6.90991 1.6875 6.62899 1.6875 6.28565V5.99849C1.6875 4.56894 3.35448 3.41406 5.41793 3.41406H15.9695C18.0329 3.41406 19.7089 4.57518 19.7089 6.00473Z" fill="#0C8654"/>
<path d="M1.6875 8.88911V12.8909C1.6875 14.7386 3.35448 16.2312 5.41793 16.2312H11.0586C11.5812 16.2312 12.0318 15.8358 11.9867 15.3679C11.8606 14.1334 12.3021 12.7941 13.5276 11.7291C14.0322 11.2854 14.6539 10.9465 15.3297 10.7529C16.456 10.4301 17.5463 10.4705 18.5105 10.7609C19.0962 10.9384 19.7089 10.5592 19.7089 10.0025V8.88104C19.7089 8.43729 19.3034 8.07422 18.8078 8.07422H2.58857C2.09298 8.08229 1.6875 8.44536 1.6875 8.88911ZM7.09392 13.5283H5.29178C4.92234 13.5283 4.61598 13.254 4.61598 12.9232C4.61598 12.5924 4.92234 12.3181 5.29178 12.3181H7.09392C7.46336 12.3181 7.76972 12.5924 7.76972 12.9232C7.76972 13.254 7.46336 13.5283 7.09392 13.5283Z" fill="#0C8654"/>
<path d="M16.71 11.5703C14.8135 11.5703 13.2773 12.9609 13.2773 14.6777C13.2773 15.2604 13.4576 15.8119 13.7751 16.278C14.3672 17.1792 15.4571 17.7851 16.71 17.7851C17.9629 17.7851 19.0528 17.1792 19.6449 16.278C19.9624 15.8119 20.1426 15.2604 20.1426 14.6777C20.1426 12.9609 18.6065 11.5703 16.71 11.5703ZM18.4864 14.3437L16.6585 15.8741C16.5384 15.9751 16.3753 16.0295 16.2208 16.0295C16.0578 16.0295 15.8947 15.9751 15.766 15.8585L14.9164 15.0895C14.6676 14.8642 14.6676 14.4913 14.9164 14.266C15.1653 14.0407 15.5772 14.0407 15.8261 14.266L16.238 14.6389L17.6111 13.4891C17.8685 13.2716 18.2804 13.2872 18.5207 13.5202C18.761 13.7533 18.7438 14.1184 18.4864 14.3437Z" fill="#0C8654"/>
<path d="M16.0143 16.6933C15.7049 16.3283 14.7723 15.5553 14.3446 15.2145C14.088 15.0071 14.3363 14.5244 14.8486 14.8644C15.2585 15.1364 15.8747 15.6594 16.1316 15.887C16.3732 14.8493 17.877 13.109 18.1283 12.8765C18.3796 12.6439 18.3796 12.6439 18.6351 12.7564C18.8395 12.8464 18.7231 13.024 18.6393 13.1015C17.2612 14.7255 16.6426 16.112 16.6468 16.457C16.6509 16.8021 16.401 17.1496 16.0143 16.6933Z" fill="white"/>
Marchand-Nicolas marked this conversation as resolved.
Show resolved Hide resolved
</svg>
);
};
Expand Down
Loading