Skip to content

Commit

Permalink
Use .NET 5.0 SDK and net5.0-windows tfm
Browse files Browse the repository at this point in the history
  • Loading branch information
wtfsck committed Nov 11, 2020
1 parent 559a7d9 commit 04915a6
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 20 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
$env:PATH = $msbuildPath + ';' + $env:PATH
.\build.ps1 core-x86
New-Item -ItemType Directory -Path C:\builtfiles -Force > $null
Compress-Archive -Path dnSpy\dnSpy\bin\Release\netcoreapp3.1\win-x86\publish\* -DestinationPath C:\builtfiles\dnSpy-netcore-win32.zip
Compress-Archive -Path dnSpy\dnSpy\bin\Release\net5.0-windows\win-x86\publish\* -DestinationPath C:\builtfiles\dnSpy-netcore-win32.zip
.\clean-all.cmd
- name: Build dnSpy (.NET Core x64)
Expand All @@ -53,7 +53,7 @@ jobs:
$env:PATH = $msbuildPath + ';' + $env:PATH
.\build.ps1 core-x64
New-Item -ItemType Directory -Path C:\builtfiles -Force > $null
Compress-Archive -Path dnSpy\dnSpy\bin\Release\netcoreapp3.1\win-x64\publish\* -DestinationPath C:\builtfiles\dnSpy-netcore-win64.zip
Compress-Archive -Path dnSpy\dnSpy\bin\Release\net5.0-windows\win-x64\publish\* -DestinationPath C:\builtfiles\dnSpy-netcore-win64.zip
.\clean-all.cmd
- uses: actions/upload-artifact@v2
Expand Down
16 changes: 8 additions & 8 deletions DnSpyCommon.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@
- build.ps1
- .github/workflows/build.yml
NOTE: Update the ABOVE files when TargetFrameworks is updated -->
<TargetFrameworks>net48;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net48;net5.0-windows</TargetFrameworks>
<IsDotNetFramework>false</IsDotNetFramework>
<IsDotNetCore>false</IsDotNetCore>
<IsSelfContainedDotNetCore>false</IsSelfContainedDotNetCore>
<IsDotNetFramework Condition=" !$(TargetFramework.StartsWith(netcoreapp)) ">true</IsDotNetFramework>
<IsDotNetCore Condition=" $(TargetFramework.StartsWith(netcoreapp)) ">true</IsDotNetCore>
<IsSelfContainedDotNetCore Condition=" '$(IsDotNetCore)' == 'true' ">true</IsSelfContainedDotNetCore>
<IsDotNet>false</IsDotNet>
<IsSelfContainedDotNet>false</IsSelfContainedDotNet>
<IsDotNetFramework Condition=" $(TargetFramework.StartsWith(net4)) ">true</IsDotNetFramework>
<IsDotNet Condition=" !$(TargetFramework.StartsWith(net4)) ">false</IsDotNet>
<IsSelfContainedDotNet Condition=" '$(IsDotNet)' == 'true' ">true</IsSelfContainedDotNet>
<Features>strict;nullablePublicOnly</Features>
<LangVersion>8.0</LangVersion>
<LangVersion Condition=" $(MSBuildProjectFile.EndsWith('.vbproj')) " >latest</LangVersion>
<NeutralLanguage>en</NeutralLanguage>
<AppDesignerFolderContentsVisibleOnlyInShowAllFiles>false</AppDesignerFolderContentsVisibleOnlyInShowAllFiles>
<!-- Make sure we don't have to publish each extension to get all their refs -->
<CopyLocalLockFileAssemblies Condition=" '$(IsDotNetCore)' == 'true' ">true</CopyLocalLockFileAssemblies>
<CopyLocalLockFileAssemblies Condition=" '$(IsDotNet)' == 'true' ">true</CopyLocalLockFileAssemblies>
<!-- If this gets updated, also update .github/workflows/build.yml and build.ps1 -->
<DnSpyRuntimeIdentifiers>win-x86;win-x64</DnSpyRuntimeIdentifiers>
<SatelliteResourceLanguages>cs;de;es;es-ES;fa;fr;hu;it;pt-BR;pt-PT;ru;tr;uk;zh-CN</SatelliteResourceLanguages>
Expand Down Expand Up @@ -48,7 +48,7 @@
<SCCompositionVersion>4.6.0</SCCompositionVersion>
</PropertyGroup>

<Import Project="$(MSBuildThisFileDirectory)Build\ConvertToNetstandardReferences\ConvertToNetstandardReferences.tasks" Condition=" '$(IsDotNetCore)' == 'true' " />
<Import Project="$(MSBuildThisFileDirectory)Build\ConvertToNetstandardReferences\ConvertToNetstandardReferences.tasks" Condition=" '$(IsDotNet)' == 'true' " />

<!-- .NET Core 3.0 SDK doesn't currently support COMReference: https://github.com/dnSpy/dnSpy/issues/1053 -->
<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion Extensions/dnSpy.Debugger/Mono.Debugger.Soft
2 changes: 1 addition & 1 deletion Libraries/ICSharpCode.TreeView
2 changes: 1 addition & 1 deletion build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ param([string]$buildtfm = 'all', [switch]$NoMsbuild)
$ErrorActionPreference = 'Stop'

$net_tfm = 'net48'
$netcore_tfm = 'netcoreapp3.1'
$netcore_tfm = 'net5.0-windows'
$configuration = 'Release'
$net_baseoutput = "dnSpy\dnSpy\bin\$configuration"
$apphostpatcher_dir = "Build\AppHostPatcher"
Expand Down
3 changes: 1 addition & 2 deletions dnSpy/dnSpy-x86/dnSpy-x86.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
<SignAssembly>True</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\dnSpy.snk</AssemblyOriginatorKeyFile>
<Nullable>enable</Nullable>
<!-- If it's .NET Core, we can only use 32-bit only or 64-bit only exes. dnSpy-x86 isn't needed. -->
<OutputPath Condition=" '$(IsDotNetCore)' != 'true' ">..\dnSpy\bin\$(Configuration)\</OutputPath>
<OutputPath Condition=" '$(IsDotNetFramework)' == 'true' ">..\dnSpy\bin\$(Configuration)\</OutputPath>

<RuntimeIdentifiers>$(DnSpyRuntimeIdentifiers)</RuntimeIdentifiers>
<OutputType>WinExe</OutputType>
Expand Down
4 changes: 2 additions & 2 deletions dnSpy/dnSpy/dnSpy.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@
<PackageReference Include="Iced" Version="$(IcedVersion)" />
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="$(MSVSCompositionVersion)" />
<PackageReference Include="Microsoft.VisualStudio.Language.Intellisense" Version="$(MSVSIntellisenseVersion)" />
<!-- Self contained .NET Core apps already ship with this DLL (not necessarily the same version, though) -->
<PackageReference Include="Microsoft.DiaSymReader.Native" Version="$(DiaSymReaderVersion)" Condition=" '$(IsSelfContainedDotNetCore)' != 'true' " />
<!-- Self contained .NET apps already ship with this DLL (not necessarily the same version, though) -->
<PackageReference Include="Microsoft.DiaSymReader.Native" Version="$(DiaSymReaderVersion)" Condition=" '$(IsSelfContainedDotNet)' != 'true' " />
<PackageReference Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="$(MSVSTextVersion)" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "3.1.200",
"version": "5.0.100",
"rollForward": "latestMinor"
}
}

0 comments on commit 04915a6

Please sign in to comment.