-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run-vmtest: introduce run-vmtest.env #166
Conversation
vmtest CI passes: kernel-patches/vmtest#326 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall aside from the fact that I don't think this works correctly as is.
Is there a way to update https://github.com/libbpf/ci/blob/main/run-vmtest/action.yml or a README to document those environment variables needed by run-vmtest.env
?
Also, I suppose this needs to be released in a version manner right? e.g landing this into main
would break CI as https://github.com/kernel-patches/vmtest/blob/78dc9a42e4c3cdbad127814f91219ee20e40dbf2/.github/workflows/kernel-test.yml#L67 fir instance, is unaware of this yet.
@chantra I added "unit tests" for run-vmtest, and rewrote the "merge lists" script. Please take a look when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there is an issue in the rewritten script which was also surfaced by CI, but otherwise this looks go to go.
d949c60
to
05b25cd
Compare
@chantra Didn't answer these in the first pass through your comments. Answering below.
It's tricky. Presumably, author of run-vmtest.env is also an author of a workflow calling On the other hand, there are I think you're right, a note about this in the readme is warranted.
Yes. This is not an issue for a while now. BPF CI is pinned to |
Update run-vmtest action to source $VMTEST_CONFIGS/run-vmtest.env when present. For detais read a comment in ci/vmtest/configs/run-vmtest.env Add scripts local to run-vmtest that handle the merge of multiple allow/denylists for BPF selftests. Passing @filename as allow/denylist to test runners, instead of inlining comma-separated test names. Add test_progs-bpf_gcc as a possible test runner in run-vmtest/run-bpf-selftests.sh Signed-off-by: Ihor Solodrai <[email protected]>
Signed-off-by: Ihor Solodrai <[email protected]>
Signed-off-by: Ihor Solodrai <[email protected]>
05b25cd
to
dbd0f03
Compare
Signed-off-by: Ihor Solodrai <[email protected]>
dbd0f03
to
2ce3f72
Compare
vmtest pipeline has passed: https://github.com/kernel-patches/vmtest/actions/runs/12776803904 Merging now. |
Add ci/vmtest/configs/run-vmtest.env to control allow/deny lists Signed-off-by: Ihor Solodrai <[email protected]>
* Add ci/vmtest/configs/run-vmtest.env to control allow/deny lists * Use v3 of libbpf/ci actions in all workflows Signed-off-by: Ihor Solodrai <[email protected]>
* vmtest.yml * use v3 of libbpf/ci actions * remove unnecessary selftests preparation steps * ci/vmtest * remove unnecessary scripts and configs * add libbpf-specific run-vmtest.env [1] [1] libbpf/ci#166
* vmtest.yml * use v3 of libbpf/ci actions * remove unnecessary selftests preparation steps * ci/vmtest * remove unnecessary scripts and configs * add libbpf-specific run-vmtest.env [1] [1] libbpf/ci#166 Signed-off-by: Ihor Solodrai <[email protected]>
* vmtest.yml * use v3 of libbpf/ci actions * remove unnecessary selftests preparation steps * ci/vmtest * remove unnecessary scripts and configs * add libbpf-specific run-vmtest.env [1] [1] libbpf/ci#166 Signed-off-by: Ihor Solodrai <[email protected]>
Update run-vmtest action to source $VMTEST_CONFIGS/run-vmtest.env when present. For detais read a comment in ci/vmtest/configs/run-vmtest.env
Add scripts local to run-vmtest that handle the merge of multiple allow/denylists for BPF selftests.
Passing @filename as allow/denylist to test runners, instead of inlining comma-separated test names.
Add test_progs-bpf_gcc as a possible test runner in run-vmtest/run-bpf-selftests.sh