Backport GH-953 to 3.11 branch #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
commented
Jan 27, 2024
| // testRobust_GEOS946 | ||
| template<> | ||
| template<> | ||
| void object::test<20>() |
There was a problem hiding this comment.
should this test number be reset to 16? Or leave as-is in-case there are other backports from main (which has the missing 16-19 tests). It doesn't seem to mind that there are gaps of test numbers.
There was a problem hiding this comment.
I've decided to leave these alone. Previously I would have reset them, but it makes potential other backports difficult to place in if they have tests before/after these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #953 to 3.11 branch
Closes #1034