Fix buffer Inverted Ring Removal check #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
reviewed
Mar 15, 2024
include/geos/geom/LineSegment.h
Outdated
| @@ -250,13 +250,20 @@ class GEOS_DLL LineSegment { | |||
| // | |||
| /// @param ret will be set to the midpoint of the segment | |||
| /// | |||
| void midPoint(Coordinate& ret) const | |||
| Coordinate midPoint() const | |||
There was a problem hiding this comment.
Suggest using CoordinateXY anywhere we are not accessing z.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
BufferCurveSetBuilder.isRingCurveInvertedcheck to avoid removing a class of raw offset curves which are in fact valid buffer curves.The check was introduced in locationtech/jts#706 and improved in locationtech/jts#878 (ported as 85ead60). But the issues reported in #984 revealed that there were still valid cases being removed incorrectly.
Fixes #984