Add PointLocation.isOnSegment function #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramsey
reviewed
Apr 23, 2024
| @@ -42,7 +58,7 @@ PointLocation::isOnLine(const geom::CoordinateXY& p, const geom::CoordinateSeque | |||
| const geom::CoordinateXY* pp = &(pt->getAt<geom::CoordinateXY>(0)); | |||
There was a problem hiding this comment.
Maybe change this to a reference so you dispense with the * further down,
There was a problem hiding this comment.
I tried that but was getting compile errors. Does it need to be a pointer because it gets revalued at the end of the loop?
There was a problem hiding this comment.
Another option is to simply define references for both points each time through the loop.
There was a problem hiding this comment.
Oh yeah, const references hate being redefined. 🤷 Nm.
pramsey
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
PointLocation.isOnSegmentfunction, and use it instead ofLineIntersector.hasIntersection.Also remove unused
LineIntersector.computeIntersection(p, p1, p2).Port of locationtech/jts#1048