Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Partial Solution for "Errors with dub test" #19

Closed
wants to merge 1 commit into from

Conversation

jmh530
Copy link
Contributor

@jmh530 jmh530 commented Oct 19, 2017

Addressing issue #15, I propose to add some configurations to the dub.json and then use preBuildCommands (I wasn't entirely sure if this is what should be used or preGenerateCommands) to run the python code necessary for the unittests.

When I make these adjustments, dub test works again on Windows and doesn't require additional work, but it seems to do the preBuildCommands multiple times (hence the comment above on preGenerateCommands).

I also believe there should be some way to detect that the commands fail, such as if python is not detected, and skip those tests. So that's why I'm referring to it as a partial solution.

@coveralls
Copy link

coveralls commented Oct 19, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 79c66a9 on jmh530:jmh530-wintest into 5678bc4 on libmir:master.

@ShigekiKarita
Copy link
Member

I also believe there should be some way to detect that the commands fail, such as if python is not detected, and skip those tests. So that's why I'm referring to it as a partial solution.

I have a plan to achieve this.

  • in numir.io, if (exists("aa.npy")) { unit-tests } else { writeln("warning: not tested") }
  • use cd test && python test.py ; cd .. instead of cd test && python test.py && cd .. to allow the ack of numpy

@ShigekiKarita ShigekiKarita mentioned this pull request Dec 9, 2017
@ShigekiKarita
Copy link
Member

@jmh530 would you check my solution updated from yours #21

@ShigekiKarita ShigekiKarita self-assigned this Dec 9, 2017
@jmh530 jmh530 closed this Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants