[PWX-36749] Bumped up SDK version and added NFS

endpoint IP format validation
libopenstorage · Apr 16, 2024 · 2c131a1 · 2c131a1
1 parent e006f0e
commit 2c131a1
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 2 deletions.
diff --git a/SDK_CHANGELOG.md b/SDK_CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Releases
 
+### v0.182.0 - (04/16/2024)
+
+* Added NFS Endpoint in volume spec
+
 ### v0.181.0 - (03/20/2024)
 
 * Add servers and APIs for defrag and schedule services

diff --git a/api/server/sdk/api/api.swagger.json b/api/server/sdk/api/api.swagger.json
diff --git a/api/spec/spec_handler.go b/api/spec/spec_handler.go
@@ -2,6 +2,7 @@ package spec
 
 import (
 	"fmt"
+	"net"
 	"regexp"
 	"strconv"
 	"strings"
@@ -655,6 +656,9 @@ func (d *specHandler) UpdateSpecFromOpts(opts map[string]string, spec *api.Volum
 			if spec.ProxySpec.PureFileSpec == nil {
 				spec.ProxySpec.PureFileSpec = &api.PureFileSpec{}
 			}
+			if net.ParseIP(v) == nil {
+				return nil, nil, nil, fmt.Errorf("invalid Pure NFS endpoint: %v", v)
+			}
 			spec.ProxySpec.PureFileSpec.NfsEndpoint = v
 		case api.SpecIoThrottleRdIOPS:
 			if spec.IoThrottle == nil {

diff --git a/api/spec/spec_handler_test.go b/api/spec/spec_handler_test.go
@@ -523,7 +523,21 @@ func TestPureNFSEndpoint(t *testing.T) {
 	require.NoError(t, err)
 	proxySpec := spec.GetProxySpec()
 	require.NotNil(t, proxySpec)
-	require.Equal(t, proxySpec.GetPureFileSpec().GetNFSEndpoint(), nfsEndpoint)
+	require.Equal(t, proxySpec.GetPureFileSpec().GetNfsEndpoint(), nfsEndpoint)
+
+	nfsEndpoint = ""
+	_, _, _, err = s.SpecFromOpts(map[string]string{
+		api.SpecPureNFSEnpoint: nfsEndpoint,
+	})
+	require.Error(t, err, "Failed to parse nfs endpoint parameter")
+	require.ErrorContains(t, err, "invalid Pure NFS endpoint")
+
+	nfsEndpoint = "abc"
+	_, _, _, err = s.SpecFromOpts(map[string]string{
+		api.SpecPureNFSEnpoint: nfsEndpoint,
+	})
+	require.Error(t, err, "Failed to parse nfs endpoint parameter")
+	require.ErrorContains(t, err, "invalid Pure NFS endpoint")
 }
 
 func TestXattr(t *testing.T) {