fix: don't default to sharedv4/shared for RWX Volumes if proxy spec is set #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glitchfix
force-pushed
the
fix/PWX-33008
branch
from
a4c475c to
7d30b0c
Compare
Glitchfix
force-pushed
the
fix/PWX-33008
branch
from
7d30b0c to
57d76df
Compare
ggriffiths
reviewed
Aug 24, 2023
Glitchfix
force-pushed
the
fix/PWX-33008
branch
from
f24c5b5 to
ed9018c
Compare
ggriffiths
approved these changes
Aug 25, 2023
|
This PR is stale because it has been in review for 3 days with no activity. |
|
@ggriffiths I think you need merge the PR |
|
This PR is stale because it has been in review for 3 days with no activity. |
…s set Signed-off-by: Shivanjan Chakravorty <[email protected]>
Signed-off-by: Shivanjan Chakravorty <[email protected]>
Glitchfix
force-pushed
the
fix/PWX-33008
branch
from
ed9018c to
2a2a6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When creating a proxy volume with CSI enabled, if you set RWX access mode, the user will hit an error. This is because we default to sharedv4 for all RWX volumes in CSI.
When defaulting to sharedv4, we need to first check if a proxy spec is set. In that case, we shouldn’t default to sharedv4.