PWX-33631: Remove global lock on getRemoteConn #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Griffiths <[email protected]>
github-actions
bot
added
area/csi
stage/in-review
size/s
and removed
stage/in-review
labels
|
Ran PVC longevity script for 10mins, all is good: |
adityadani
approved these changes
Sep 14, 2023
ggriffiths
pushed a commit
to ggriffiths/openstorage
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
pushed a commit
that referenced
this pull request
Sep 19, 2023
* PWX-33631: Hold round-robin lock only when needed (#2335) Signed-off-by: Grant Griffiths <[email protected]> * PWX-33631: Remove global lock on getRemoteConn (#2339) Signed-off-by: Grant Griffiths <[email protected]> --------- Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
pushed a commit
to ggriffiths/openstorage
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
pushed a commit
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Grant Griffiths <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were taking two redundant locks: One inside of pkg/loadbalancer and once inside of the CSI function that called into pkg/loadbalancer. This removes the CSI lock.
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: