Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chattr exits with status 1 for files that are not permitted without force flag #2351

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: chattr exits with status 1 for files that are not permitted without force flag #2351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 41 additions & 4 deletions pkg/chattr/chattr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,32 @@ const (
)

func AddImmutable(path string) error {
return ForceAddImmutable(path, false)
}

func ForceAddImmutable(path string, force bool) error {
chattrBin := which(chattrCmd)
if _, err := os.Stat(path); err == nil {
cmd := exec.Command(chattrBin, "+i", path)
var cmd *exec.Cmd
if force {
cmd = exec.Command(chattrBin, "+i", "-f", path)
} else {
cmd = exec.Command(chattrBin, "+i", path)
}
var stderr bytes.Buffer
cmd.Stderr = &stderr

if err = cmd.Run(); err != nil {
err = cmd.Run()
if err != nil {
// chattr exits with status 1 for files that are not permitted without force flag
// this will happen for files that throws the error
// "Operation not supported while reading flags"
if force && cmd.ProcessState.ExitCode() == 1 {
return nil
}
if force {
return fmt.Errorf("%s +i -f failed: %s. Err: %v", chattrBin, stderr.String(), err)
}
return fmt.Errorf("%s +i failed: %s. Err: %v", chattrBin, stderr.String(), err)
}
}
Expand All @@ -32,13 +51,31 @@ func AddImmutable(path string) error {
}

func RemoveImmutable(path string) error {
return ForceRemoveImmutable(path, false)
}
func ForceRemoveImmutable(path string, force bool) error {
chattrBin := which(chattrCmd)
if _, err := os.Stat(path); err == nil {
cmd := exec.Command(chattrBin, "-i", path)
var cmd *exec.Cmd
if force {
cmd = exec.Command(chattrBin, "-i", "-f", path)
} else {
cmd = exec.Command(chattrBin, "-i", path)
}
var stderr bytes.Buffer
cmd.Stderr = &stderr

if err = cmd.Run(); err != nil {
err = cmd.Run()
if err != nil {
// chattr exits with status 1 for files that are not permitted without force flag
// this will happen for files that throws the error
// "Operation not supported while reading flags"
if force && cmd.ProcessState.ExitCode() == 1 {
return nil
}
if force {
return fmt.Errorf("%s -i -f failed: %s. Err: %v", chattrBin, stderr.String(), err)
}
return fmt.Errorf("%s -i failed: %s. Err: %v", chattrBin, stderr.String(), err)
}
}
Expand Down
Loading