Add cpu cores to storage node #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dahuang <[email protected]>
dahuang-purestorage
force-pushed
the
PWX-34038-add-cpu-cores-to-storage
branch
from
584371b to
0f6649b
Compare
ggriffiths
approved these changes
Oct 4, 2023
dahuang-purestorage
added a commit
that referenced
this pull request
Oct 4, 2023
Adds cpu core number as api.Node field for telemetry. JIRA: PWX-34038 Signed-off-by: dahuang <[email protected]>
dahuang-purestorage
added a commit
that referenced
this pull request
Oct 5, 2023
Adds cpu core number as api.Node field for telemetry. JIRA: PWX-34038 Signed-off-by: dahuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds CPU cores as part of the API Node field. Makes sure it gets updated too.
Which issue(s) this PR fixes (optional)
PWX-34038
Testing Notes
Vendored this into px and was able to get cpu Core to display on loggly and
pxctl status