Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstorage changes for new fsck CLI - List snaps, Delete snaps, List vols #2353

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

ppadalia
Copy link
Collaborator

@ppadalia ppadalia commented Oct 4, 2023

What this PR does / why we need it:
Openstorage changes for new fsck CLI - List snaps, Delete snaps, List vols

Which issue(s) this PR fixes (optional)
PWX-33965

Testing Notes
N/A - Will be uploaded on porx PR
https://github.com/portworx/porx/pull/12350

list-snapshots

14:04:13  time=2023-10-20T08:34:13Z level=info msg=SSHCMD: [[email protected]:22]# sudo sudo /opt/pwx/bin/pxctl volume check list-snapshots volumeFsckListDelSnaps1
14:04:13  time=2023-10-20T08:34:13Z level=info msg=SSHOUT: [[email protected]:22]#
14:04:13  Volume Snapshot ID	Volume Snapshot Name
14:04:13  764638784223047136	volumeFsckListDelSnaps1_fsck_snap_2023_Oct_20_08_34_01
14:04:13  963046767004546850	volumeFsckListDelSnaps1_fsck_snap_2023_Oct_20_08_33_49

14:04:13  time=2023-10-20T08:34:13Z level=info msg=SSHCMD: [[email protected]:22]# sudo sudo /opt/pwx/bin/pxctl volume check list-snapshots volumeFsckListDelSnaps1 -j
14:04:13  time=2023-10-20T08:34:13Z level=info msg=SSHOUT: [[email protected]:22]#
14:04:13  {
14:04:13   "snapshots": {
14:04:13    "764638784223047136": {
14:04:13     "volume_snapshot_name": "volumeFsckListDelSnaps1_fsck_snap_2023_Oct_20_08_34_01"
14:04:13    },
14:04:13    "963046767004546850": {
14:04:13     "volume_snapshot_name": "volumeFsckListDelSnaps1_fsck_snap_2023_Oct_20_08_33_49"
14:04:13    }
14:04:13   }
14:04:13  }

delete-snapshots

14:04:13  time=2023-10-20T08:34:13Z level=info msg=SSHCMD: [[email protected]:22]# sudo sudo /opt/pwx/bin/pxctl volume check delete-snapshots volumeFsckListDelSnaps1
14:04:14  time=2023-10-20T08:34:13Z level=info msg=SSHOUT: [[email protected]:22]#
14:04:14  Filesystem-check delete-snapshots request completed. All fsck created snapshots for the specified volume will be deleted.
14:04:14  Issue 'pxctl volume check list-snapshots <volname>' or check cluster alerts to confirm the deletion of snapshots.
14:04:14  

list-volumes

12:16:44  time=2023-10-20T06:46:43Z level=info msg=SSHCMD: [[email protected]:22]# sudo sudo /opt/pwx/bin/pxctl volume check list-volumes
12:16:44  time=2023-10-20T06:46:43Z level=info msg=SSHOUT: [[email protected]:22]#
12:16:44  Volume ID		Volume Name		Health Status				Volume Has FS Errors
12:16:44  292449395648734571	volumeFsckListVolumes_7	FS_HEALTH_STATUS_SAFE_TO_FIX		no
12:16:44  175374481142876324	volumeFsckListVolumes_5	FS_HEALTH_STATUS_SAFE_TO_FIX		no
12:16:44  955821806768222836	volumeFsckListVolumes_1	FS_HEALTH_STATUS_NEEDS_INSPECTION	no
12:16:44  504247086299902947	volumeFsckListVolumes_9	FS_HEALTH_STATUS_SAFE_TO_FIX		no
12:16:44  204242062023435478	volumeFsckListVolumes_3	FS_HEALTH_STATUS_NEEDS_INSPECTION	no

time=2023-10-20T06:46:43Z level=info msg=SSHCMD: [[email protected]:22]# sudo sudo /opt/pwx/bin/pxctl volume check list-volumes -j
12:16:44  time=2023-10-20T06:46:43Z level=info msg=SSHOUT: [[email protected]:22]#
12:16:44  {
12:16:44   "volumes": {
12:16:44    "175374481142876324": {
12:16:44     "volume_name": "volumeFsckListVolumes_5",
12:16:44     "health_status": 2
12:16:44    },
12:16:44    "204242062023435478": {
12:16:44     "volume_name": "volumeFsckListVolumes_3",
12:16:44     "health_status": 3
12:16:44    },
12:16:44    "292449395648734571": {
12:16:44     "volume_name": "volumeFsckListVolumes_7",
12:16:44     "health_status": 2
12:16:44    },
12:16:44    "504247086299902947": {
12:16:44     "volume_name": "volumeFsckListVolumes_9",
12:16:44     "health_status": 2
12:16:44    },
12:16:44    "955821806768222836": {
12:16:44     "volume_name": "volumeFsckListVolumes_1",
12:16:44     "health_status": 3
12:16:44    }
12:16:44   }
12:16:44  }

Special notes for your reviewer:
N/A

@github-actions
Copy link

This PR is stale because it has been in review for 3 days with no activity.

api/api.proto Outdated Show resolved Hide resolved
api/api.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@sulakshm sulakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for one request submitted as POST vs GET rest all are minor nits from my end.

@ppadalia ppadalia marked this pull request as ready for review October 20, 2023 05:49
@ppadalia ppadalia requested a review from sulakshm October 20, 2023 08:41
@ppadalia ppadalia force-pushed the fsck_new_cli branch 5 times, most recently from 34e80fc to b6da08c Compare October 25, 2023 13:35
@ppadalia ppadalia merged commit dbdc215 into master Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants