-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openstorage changes for new fsck CLI - List snaps, Delete snaps, List vols #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppadalia
force-pushed
the
fsck_new_cli
branch
12 times, most recently
from
October 9, 2023 15:30
0a62cd4
to
bb850e1
Compare
This PR is stale because it has been in review for 3 days with no activity. |
sulakshm
reviewed
Oct 20, 2023
sulakshm
reviewed
Oct 20, 2023
sulakshm
reviewed
Oct 20, 2023
sulakshm
reviewed
Oct 20, 2023
sulakshm
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for one request submitted as POST vs GET rest all are minor nits from my end.
ppadalia
force-pushed
the
fsck_new_cli
branch
from
October 20, 2023 05:21
bb850e1
to
6ee8818
Compare
ppadalia
force-pushed
the
fsck_new_cli
branch
5 times, most recently
from
October 25, 2023 13:35
34e80fc
to
b6da08c
Compare
sulakshm
approved these changes
Oct 26, 2023
… vols Signed-off-by: Prince <[email protected]>
ppadalia
force-pushed
the
fsck_new_cli
branch
from
November 2, 2023 11:26
b6da08c
to
5fdbf75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Openstorage changes for new fsck CLI - List snaps, Delete snaps, List vols
Which issue(s) this PR fixes (optional)
PWX-33965
Testing Notes
N/A - Will be uploaded on porx PR
https://github.com/portworx/porx/pull/12350
list-snapshots
delete-snapshots
list-volumes
Special notes for your reviewer:
N/A