PWX-34326: CSI - fix GetPluginInfo version for CSI #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
commented
Oct 11, 2023
| @@ -24,8 +24,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| // CSI 1.4 compatible | |||
| csiDriverVersion = "1.4.0" | |||
There was a problem hiding this comment.
Nomad shows this version in the CLI output, so we need to have the correct version exposed here via GetPluginInfo
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Grant Griffiths <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
pushed a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Grant Griffiths <[email protected]> Co-authored-by: Grant Griffiths <[email protected]>
ggriffiths
pushed a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Grant Griffiths <[email protected]> Co-authored-by: Grant Griffiths <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Nomad shows this version in the CLI output, so we need to have the correct version exposed here via GetPluginInfo
Which issue(s) this PR fixes (optional)
PWX-34326
Testing Notes
Not needed
Special notes for your reviewer:
n/a