Add integrity flag to volume spec #2365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been in review for 3 days with no activity. |
sulakshm
reviewed
Oct 31, 2023
api/api.proto
Outdated
| @@ -714,6 +714,8 @@ message VolumeSpec { | |||
| bool near_sync = 51; | |||
| // NearSyncReplicationStrategy is replication strategy for near sync volumes | |||
| NearSyncReplicationStrategy near_sync_replication_strategy = 52; | |||
| // Integrity is true if data for the volume will be checksumed | |||
| bool integrity = 53; | |||
There was a problem hiding this comment.
why not call it checksum itself?
cnbu-jenkins
force-pushed
the
integrity_flag
branch
4 times, most recently
from
af6412d to
fe0713d
Compare
Signed-off-by: Vivek Patidar <[email protected]>
cnbu-jenkins
force-pushed
the
integrity_flag
branch
from
fe0713d to
64952b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added new flag for creating integrity volumes.
Which issue(s) this PR fixes (optional)
Closes # PWX-34423
Testing Notes
Add testing output or passing unit test output here.
Special notes for your reviewer:
Add any notes for the reviewer here.