PWX-28654 Add quorum member flag to the StorageNode SDK object #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is populated from cluster database's NonQuorumMember field. Which in turn is calculated in QuorumMember() listener function impl in PX. It looks at the storage devices in the metadata store. Signed-off-by: Piyush Nimbalkar <[email protected]>
pureneelesh
approved these changes
Oct 25, 2023
| @@ -746,6 +748,7 @@ func (c *ClusterManager) joinCluster( | |||
| selfNodeEntry.NonQuorumMember = | |||
| selfNodeEntry.Status == api.Status_STATUS_DECOMMISSION || | |||
| !c.quorumMember() | |||
| c.selfNode.NonQuorumMember = selfNodeEntry.NonQuorumMember | |||
There was a problem hiding this comment.
You probably checked it already but wondering if should set NonQuorumMember on line 597 in initNode() as well.
There was a problem hiding this comment.
initNode() is called before the listeners are initialized. The caller of the initNode() is initListeners(), which does things in the following order -
initNode() - create a node object
initNodeInCluster() - initializes all the listeners
quorumMember() - this calls QuorumMember() on the now initialized PX listener
In this PR we are setting the quorum member flag after the above steps. We set it in both the selfNode and the node entry that will get stored in the cluster database.
piyush-nimbalkar
force-pushed
the
master_pwx-28654
branch
from
8f9d707 to
913b4f2
Compare
|
Thank you for the quick review, @pureneelesh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This field is populated from cluster database's NonQuorumMember field. Which in turn is calculated in QuorumMember() listener function impl in PX. It looks at the storage devices in the metadata store.
Which issue(s) this PR fixes (optional)
Closes #
or
PWX-28654
Testing Notes
Sample output from a 6 node cluster with 3 storage nodes:
Special notes for your reviewer:
Add any notes for the reviewer here.