fix: throw error if volume is down state and with pending status, it might not recover #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnookala-px
approved these changes
Dec 13, 2023
Glitchfix
force-pushed
the
fix/vol-down-dont-wait
branch
from
7a46045 to
c0358f7
Compare
…might not recover Signed-off-by: Shivanjan Chakravorty <[email protected]>
Signed-off-by: Shivanjan Chakravorty <[email protected]>
Glitchfix
force-pushed
the
fix/vol-down-dont-wait
branch
from
c0358f7 to
8eb7d36
Compare
Glitchfix
added a commit
to Glitchfix/openstorage
that referenced
this pull request
Dec 15, 2023
…might not recover (libopenstorage#2383) * fix: throw error if volume is down state and with pending status, it might not recover Signed-off-by: Shivanjan Chakravorty <[email protected]> * refactor: update error message for volume state down and pending Signed-off-by: Shivanjan Chakravorty <[email protected]> --------- Signed-off-by: Shivanjan Chakravorty <[email protected]>
Glitchfix
added a commit
that referenced
this pull request
Dec 15, 2023
…might not recover (#2383) * fix: throw error if volume is down state and with pending status, it might not recover Signed-off-by: Shivanjan Chakravorty <[email protected]> * refactor: update error message for volume state down and pending Signed-off-by: Shivanjan Chakravorty <[email protected]> --------- Signed-off-by: Shivanjan Chakravorty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In case the underlying storage driver fails to create the volume and puts it in down state and keep it pending forever due to kvdb miss, it could also be that it is unable to rollback too since the kvdb is down.
the check added helps us break out of that loop.
Which issue(s) this PR fixes (optional)
PWX-35130
Testing Notes
While creating a volume if the kvdb is unavailable and the volume enters a down state
CSI should throw an error