Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec handler and change internal name for fs format options #2384

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

ppadalia
Copy link
Collaborator

What this PR does / why we need it:
Fix spec handler and change internal name for fs format options

Which issue(s) this PR fixes (optional)
Closes #PWX-18297

Testing Notes
Please refer to porx PR for UT: https://github.com/portworx/porx/pull/12772

Special notes for your reviewer:
Add any notes for the reviewer here.

Copy link
Contributor

@talakad talakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookd good to me. Adding Aditya Daani to review as well for any regressions

api/api.proto Show resolved Hide resolved
@ppadalia ppadalia merged commit 3917cf6 into master Dec 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants