PWX-35452: Fix mount/unmount race by using MountsInProgress to track … #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnookala-px
requested review from
adityadani,
ggriffiths,
pureneelesh and
sharma-tapas
Signed-off-by: pnookala-px <[email protected]>
pnookala-px
force-pushed
the
pwx-35452
branch
from
f3edb56 to
99697b0
Compare
adityadani
approved these changes
Dec 20, 2023
pnookala-px
added a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: pnookala-px <[email protected]>
pnookala-px
added a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: pnookala-px <[email protected]>
pnookala-px
added a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: pnookala-px <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mounts that are in progress
What this PR does / why we need it:
There is a race condition between Mount and Unmount and the map that tracks the mounted devices can be removed from the mount even as mounts are in progress. This will result in threads that are trying to mount/unmount further hang or fail.
Which issue(s) this PR fixes (optional)
Closes #
or
PWX-35452
Testing Notes
Testing in Progress.