Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-35451-pt2: NFS-proxy volumes fix #2394

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

zoxpx
Copy link
Contributor

@zoxpx zoxpx commented Dec 20, 2023

  • adding VolumeSpec.IsNFSProxyVolume()

What this PR does / why we need it:

Adding a convenient method to query if a volume is a NFS-proxy volume.

Which issue(s) this PR fixes (optional)

PWX-35451 - part2

Testing Notes

Tested together w/ https://github.com/portworx/porx/pull/12814 PR

Special notes for your reviewer:

* adding `VolumeSpec.IsNFSProxyVolume()`

Signed-off-by: Zoran Rajic <[email protected]>
@zoxpx zoxpx requested a review from a team December 20, 2023 19:16
@zoxpx zoxpx self-assigned this Dec 20, 2023
@zoxpx zoxpx requested a review from ggriffiths as a code owner December 20, 2023 19:16
Copy link
Contributor

@Pure-AdamuKaapan Pure-AdamuKaapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoxpx
Copy link
Contributor Author

zoxpx commented Dec 22, 2023

Thanks for the review Adam --

As the next step, need to figure out how to get this change into porx-3.1.0

@zoxpx zoxpx merged commit 8e1460c into master Dec 22, 2023
5 checks passed
@zoxpx zoxpx deleted the PWX-35451_pt2_nfs_proxy_vols_fix branch December 22, 2023 00:15
zoxpx added a commit that referenced this pull request Dec 22, 2023
* adding `VolumeSpec.IsNFSProxyVolume()`

Signed-off-by: Zoran Rajic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants