PWX-35601 Add length check before accessing in round robin #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dahuang <[email protected]>
alicelyy
reviewed
Jan 10, 2024
nrevanna
approved these changes
Jan 11, 2024
pureneelesh
reviewed
Jan 11, 2024
Signed-off-by: dahuang <[email protected]>
pureneelesh
approved these changes
Jan 11, 2024
dahuang-purestorage
added a commit
that referenced
this pull request
Jan 11, 2024
* Add length check before accessing in round robin This PR adds a few check before accessing the filteredNodes: 1. If the length is zero, we return empty string and false (isRemote) 2. Before accessing the array, we take a reminder of the currentIndex with the length of the array. JIRA: PWX-35601 Signed-off-by: dahuang <[email protected]>
dahuang-purestorage
added a commit
that referenced
this pull request
Jan 11, 2024
…2400) * Add length check before accessing in round robin This PR adds a few check before accessing the filteredNodes: 1. If the length is zero, we return empty string and false (isRemote) 2. Before accessing the array, we take a reminder of the currentIndex with the length of the array. JIRA: PWX-35601 Signed-off-by: dahuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a few check before accessing the filteredNodes:
Which issue(s) this PR fixes (optional)
PWX-35601
Testing Notes
Added simple UT to check the function