PWX-36415: Allow option to force drive add for pool expand. #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp511
force-pushed
the
PWX-36415-force-disk-add
branch
from
e3410ff to
a1b5a19
Compare
Signed-off-by: Priyanshu Pandey <[email protected]>
pp511
force-pushed
the
PWX-36415-force-disk-add
branch
from
a1b5a19 to
0c8b8aa
Compare
nrevanna
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add drive is blocked on DMthin.
This change allows a force option to override that behavior.
Which issue(s) this PR fixes (optional)
PWX-3641
Special notes for your reviewer:
Testing notes and implementation details in Porx PR https://github.com/pure-px/porx/pull/13120