-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-36843 Add --resume flag for checksum verification command #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is stale because it has been in review for 3 days with no activity. |
nikhil-bhupale
force-pushed
the
PWX-36843
branch
2 times, most recently
from
April 30, 2024 07:04
6c74a5c
to
76106d4
Compare
Added flag ResumeFromSavedOffset to verify-checksum start command Signed-off-by: nikhil-bhupale <[email protected]>
nikhil-bhupale
force-pushed
the
PWX-36843
branch
from
April 30, 2024 09:23
76106d4
to
1e73505
Compare
talakad
approved these changes
Apr 30, 2024
nikhil-bhupale
added a commit
that referenced
this pull request
Jul 22, 2024
Added flag ResumeFromSavedOffset to verify-checksum start command
nikhil-bhupale
added a commit
that referenced
this pull request
Jul 22, 2024
Added flag ResumeFromSavedOffset to verify-checksum start command
nikhil-bhupale
added a commit
that referenced
this pull request
Jul 23, 2024
Added flag ResumeFromSavedOffset to verify-checksum start command Signed-off-by: nikhil-bhupale <[email protected]>
nikhil-bhupale
added a commit
that referenced
this pull request
Jul 23, 2024
Added flag ResumeFromSavedOffset to verify-checksum start command Signed-off-by: nikhil-bhupale <[email protected]>
twang-ps
added a commit
to twang-ps/openstorage
that referenced
this pull request
Sep 24, 2024
…libopenstorage#2435)" This reverts commit 95aa0d2. Signed-off-by: Tengxiao Wang <[email protected]>
twang-ps
added a commit
that referenced
this pull request
Sep 24, 2024
* Revert "PWX-36843 Add --resume flag for checksum verification command (#2435)" This reverts commit 95aa0d2. * Revert "PWX-33692 Add new CLI to trigger checksum validation" This reverts commit be8c82f. --------- Signed-off-by: Tengxiao Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added flag ResumeFromSavedOffset to verify-checksum start command
Verified command with differenet combinations of command
root@ip-10-13-111-214:~# pxctl v verify-checksum start vol3 --resume=false
status code : VERIFY_CHECKSUM_STARTED
Verify checksum started
root@ip-10-13-111-214:~# pxctl v verify-checksum start vol3 --resume=true
status code : VERIFY_CHECKSUM_STARTED
Verify checksum started
root@ip-10-13-111-214:~# pxctl v verify-checksum start vol3
status code : VERIFY_CHECKSUM_STARTED
Verify checksum started