Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-36850: reduce verbosity of frequent ops by making those Debug #2447

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

pnookala-px
Copy link
Contributor

PWX-36850
Reduce log message level from Into to Debug to avoid log flooding.

Copy link
Contributor

@dtalreja-px dtalreja-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpabon
Copy link
Member

lpabon commented Jun 4, 2024

I can confirm that the test TestAlertsServerEnumerate also fails in master:

[nix-shell:~/git/golang/openstorage/api/server/sdk]$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

[nix-shell:~/git/golang/openstorage/api/server/sdk]$ go test -v
=== RUN   TestAlertsServerEnumerate
    sdk_test.go:170: 
        	Error Trace:	/home/lpabon/git/golang/openstorage/api/server/sdk/sdk_test.go:170
        	            				/home/lpabon/git/golang/openstorage/api/server/sdk/alerts_test.go:319
        	Error:      	Expected nil, but got: &errors.errorString{s:"Failed to connect gRPC server localhost:30549: context deadline exceeded"}
        	Test:       	TestAlertsServerEnumerate
--- FAIL: TestAlertsServerEnumerate (60.04s)
panic: runtime error: invalid memory address or nil pointer dereference
	panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x93377a]

goroutine 86 [running]:
testing.tRunner.func1.2({0x176cf40, 0x2ba2590})
	/home/lpabon/apps/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/home/lpabon/apps/go/src/testing/testing.go:1634 +0x377
panic({0x176cf40?, 0x2ba2590?})
	/home/lpabon/apps/go/src/runtime/panic.go:770 +0x132
google.golang.org/grpc.(*ClientConn).Close(0x0)
	/home/lpabon/git/golang/openstorage/vendor/google.golang.org/grpc/clientconn.go:972 +0x3a
github.com/libopenstorage/openstorage/api/server/sdk.(*testServer).Stop(0xc00018e9c0)
	/home/lpabon/git/golang/openstorage/api/server/sdk/sdk_test.go:297 +0x48
panic({0x176cf40?, 0x2ba2590?})
	/home/lpabon/apps/go/src/runtime/panic.go:770 +0x132
google.golang.org/grpc.(*ClientConn).NewStream(0x17374c0?, {0x1eaee00?, 0x2c45180?}, 0x0?, {0x1a0710b?, 0xc000f88360?}, {0x0?, 0xc000f83de8?, 0x41156a?})
	/home/lpabon/git/golang/openstorage/vendor/google.golang.org/grpc/stream.go:144 +0x32
github.com/libopenstorage/openstorage/api.(*openStorageAlertsClient).EnumerateWithFilters(0xc0004ff760?, {0x1eaee00?, 0x2c45180?}, 0x2bbdf40, {0x0?, 0x1f8b5e2?, 0xf?})
	/home/lpabon/git/golang/openstorage/api/api.pb.go:45062 +0x67
github.com/libopenstorage/openstorage/api/server/sdk.TestAlertsServerEnumerate(0xc00001e340)
	/home/lpabon/git/golang/openstorage/api/server/sdk/alerts_test.go:337 +0x27e
testing.tRunner(0xc00001e340, 0x1a90ff0)
	/home/lpabon/apps/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/home/lpabon/apps/go/src/testing/testing.go:1742 +0x390
exit status 2
FAIL	github.com/libopenstorage/openstorage/api/server/sdk	60.060s

@lpabon
Copy link
Member

lpabon commented Jun 4, 2024

Confirmed that in release-9.8 branch it also fails with the same error

@pnookala-px pnookala-px merged commit cbb5901 into master Jun 5, 2024
4 of 5 checks passed
pnookala-px added a commit that referenced this pull request Jun 5, 2024
pnookala-px added a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants