PWX-37650: Supports adding the pod name as a locator label for clone/snap restore #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
stage/in-review
area/api
area/csi
area/sdk-server
size/s
labels
…snap restore Signed-off-by: Adam Krpan <[email protected]>
Pure-AdamuKaapan
force-pushed
the
PWX-37650-master
branch
from
5f9e92a to
3a7c483
Compare
pp511
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we make a clone of a volume, or restore from a snapshot, we only get the name info of the volume. We do not get parameters like the pod name, which are required to determine where to place the volume. This adds the pod name as a label in the locator.
Which issue(s) this PR fixes (optional)
PWX-37650
Testing Notes
Confirmed volume clones are placed correctly inside of pods as expected.