Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-38611 : Replacing gob.Register with gob.RegisterName #2472

Merged
merged 1 commit into from
Aug 27, 2024
Merged

PWX-38611 : Replacing gob.Register with gob.RegisterName #2472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cluster/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,7 +1509,9 @@ func (c *ClusterManager) StartWithConfiguration(
c.system = systemutils.New()

// Start the gossip protocol.
gob.Register(api.Node{})
// Replacing gob.Register with gob.RegisterName to avoid any issue caused due to the movement from portworx to pure-px
// gossip: Error in unmarshalling peer's local data. Error : gob: name not registered for interface.
gob.RegisterName("github.com/portworx/porx/vendor/github.com/libopenstorage/openstorage/api.Node", api.Node{})
quorumTimeout := types.DEFAULT_QUORUM_TIMEOUT
if c.config.QuorumTimeoutInSeconds > 0 {
quorumTimeout = time.Duration(c.config.QuorumTimeoutInSeconds) * time.Second
Expand Down
Loading