PWX-38611 : Replacing gob.Register with gob.RegisterName while passing the actual path from PX #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the value from px Signed-off-by: Dolly Talreja <[email protected]>
adityadani
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With recent update from portworx to pure-px, we were seeing errors during porx upgrade in decoding of gossip message.
"gossip: Error in unmarshalling peer's local data. Error : gob: name not registered for interface: "github.com/portworx/porx/vendor/github.com/libopenstorage/openstorage/api.Node"
Since the latest porx was not able to decipher the old path, we have changes gob.Register() to gob.RegisterName() to explicitly inform the complete path.
Which issue(s) this PR fixes (optional)
Closes #
PWX-38452 and PWX-38611
Testing Notes
Tested the below scenarios -
Upgrade a 3 node cluster from 3.1.4 to 3.2.0 using operator 24.1.1
Upgrade a 3 node cluster from 3.1.4 to 3.2.0 using operator 24.2.0-dev
Sequentially Upgrade a 10 node cluster from 3.1.4 to 3.2.0 using operator 24.2.0-dev
parallel upgrade (4 nodes at a time )a 10 node cluster from 3.1.4 to 3.2.0 using operator 24.2.0-dev
Special notes for your reviewer:
we are not seeing the log anymore "gossip: Error in unmarshalling peer's local data. Error : gob: name not registered for interface: "github.com/portworx/porx/vendor/github.com/libopenstorage/openstorage/api.Node"