-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-39364 - Add support for Cloud snapshots in CSI #2492
Merged
sradhakrishnan-px
merged 1 commit into
feature-CSI-Cloud-Snapshots
from
sradhakrishnan/PWX-39364
Oct 11, 2024
Merged
PWX-39364 - Add support for Cloud snapshots in CSI #2492
sradhakrishnan-px
merged 1 commit into
feature-CSI-Cloud-Snapshots
from
sradhakrishnan/PWX-39364
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4990734
to
7ba4f65
Compare
fbb6a2f
to
ec1827e
Compare
Signed-off-by: Shyam Radhakrishnan <[email protected]>
ec1827e
to
03da896
Compare
pnookala-px
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
twang-ps
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pr verify output
|
Unit testa re passing except alerts_test and sdk_test which are failing in 9.9 branch as well
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Explain the PR and why it is needed.
This PR cherrypicks commits present in the PRs #2417 and #2271 to release-9.9 branch.
The original change introduced cloud snapshot capability via CSI. The APIs which have been changed are DeleteSnapshot/CreateSnapshot/CreateVolume and ListSnapshots.
Some modifications have been made to the original PR to make the delete snapshot logic better and fix unit tests. The PR also added facility to list snapshot API for cloud snapshots. Please note that Kubernetes only calls ListSnapshots for a single snapshot ID, during predefined snapshot(please see the section For pre-provisioned snapshots in the doc https://kubernetes.io/docs/concepts/storage/volume-snapshots/#volume-snapshot-contents)
Which issue(s) this PR fixes (optional)
Closes #
or
PWX-39364
Testing Notes
Add testing output or passing unit test output here.
Special notes for your reviewer:
Add any notes for the reviewer here.