Implementation of storageops for Azure Disks #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyush-nimbalkar
force-pushed
the
master
branch
from
d7559db to
3fb6b76
Compare
disrani-px
reviewed
Mar 19, 2019
piyush-nimbalkar
force-pushed
the
master
branch
from
f1b4085 to
fa7870c
Compare
disrani-px
approved these changes
Mar 20, 2019
piyush-nimbalkar
force-pushed
the
master
branch
3 times, most recently
from
fcbfe6b to
a181e13
Compare
added 5 commits
March 21, 2019 11:59
Signed-off-by: Piyush Nimbalkar <[email protected]>
This is using an older azure sdk v14.0.0 Signed-off-by: Piyush Nimbalkar <[email protected]>
Signed-off-by: Piyush Nimbalkar <[email protected]>
Signed-off-by: Piyush Nimbalkar <[email protected]>
Addressed other review comments Signed-off-by: Piyush Nimbalkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds some Azure managed disk operations to implement storageops interface.
Here we are using an older version of sdk due to some grpc conflicts.
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: