Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-6687 : Add support for retrieving px secret env from stork deploy #1728

Closed
wants to merge 1 commit into from

Conversation

vikasit12
Copy link
Contributor

@vikasit12 vikasit12 commented Apr 21, 2024

What type of PR is this?

Uncomment only one and also add the corresponding label in the PR:
bug

What this PR does / why we need it:
This PR gets secret env from stork deploy used in nfs restore of secured portworx volumes. The access key retrieved is passed as env variable in nfs restore job to complete nfs restore. We need these changes for portworx/kdmp#360

Does this PR change a user-facing CRD or CLI?:
No

Is a release note needed?:
No

Does this change need to be cherry-picked to a release branch?:
Yes release-24.1.0

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.22%. Comparing base (ca72e62) to head (c5d1105).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   48.25%   48.22%   -0.04%     
==========================================
  Files          49       49              
  Lines        8741     8741              
==========================================
- Hits         4218     4215       -3     
- Misses       4154     4156       +2     
- Partials      369      370       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vikasit12 vikasit12 closed this Apr 29, 2024
@vikasit12 vikasit12 deleted the PB-6687 branch April 29, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant