This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat: sync binaries from dist.ipfs.io #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reuses work from ipfs/kubo#8494
lidel
changed the title
vyzo
approved these changes
Dec 1, 2021
marten-seemann
approved these changes
Dec 3, 2021
| - name: Setup go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: '1.16' |
There was a problem hiding this comment.
Should we use 1.17 here?
There was a problem hiding this comment.
Afaik go-ipfs does not use 1.17, so no (we use this nly for getting latest go-ipfs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a daily check that will fetch prebuilt artifacts from https://dist.ipfs.io/#libp2p-relay-daemon
This is important because macOS binaries need to be signed and notarized, and we do that at dist.ipfs.io
It reuses work from ipfs/kubo#8494 and you can see its result in https://github.com/libp2p/go-libp2p-relay-daemon/releases/tag/v0.1.0 where it attached binaries (including signed darwin ones).
I'd like to merge this as-is, but filled ipfs/distributions#503 to turn this into proper reusable action.