Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update mdns example and docs #3056

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: update mdns example and docs #3056

wants to merge 3 commits into from
+16 −9

Conversation

2color
Copy link
Contributor

@2color 2color commented Mar 19, 2025 •
edited
Loading

Title

  • Updates usage example for mdns to make it clear that you need to explicitly dial discovered peers.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@2color 2color requested a review from a team as a code owner March 19, 2025 12:27
@2color 2color requested review from achingbrain and maschad March 28, 2025 12:45
@2color 2color requested a review from maschad April 1, 2025 11:33
maschad
maschad approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2color @maschad