Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdns): remove unnecessary question about loopback addresses #571

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+0 −4
Open

fix(mdns): remove unnecessary question about loopback addresses #571

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6de977b
fix(mdns): require loopback addresses to be ignored
maschad Sep 1, 2023
1e3aa9c
fix(mdns): require loopback addresses to be ignored
maschad Sep 1, 2023
c55d3fa
chore: update grammar + formatting
maschad Sep 1, 2023
203bacc
chore: remove the issues section and place recommendation in responses
maschad Sep 4, 2023
4a5bb0a
Merge branch 'master' into fix/update-mdns-link-local
maschad Sep 4, 2023
6e7883d
mdns: remove issue regarding loopback addresses
maschad Sep 22, 2023
b39e434
Merge branch 'master' into fix/update-mdns-link-local
maschad Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions discovery/mdns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ The **additional records** of the response contain the peer's discovery details:

The TXT record contains the multiaddresses that the peer is listening on. Each multiaddress is a TXT attribute with the form `dnsaddr=/.../p2p/QmId`. Multiple `dnsaddr` attributes and/or TXT records are allowed.

Note that `mDNS` requires link-local addresses. Loopback and "NAT busting" addresses should not be sent and must be ignored on receipt.
maschad marked this conversation as resolved.
Show resolved Hide resolved

## DNS Service Discovery

DNS-SD support is not needed for peers to discover each other. However, it is extremely useful for network administrators to discover what is running on the network.
Expand Down Expand Up @@ -118,9 +120,6 @@ Many existing tools ignore the Additional Records, and always send individual qu
- `<host-name> A`
- `<host-name> AAAA`

## Issues

[ ] mDNS requires link-local addresses. Loopback and "NAT busting" addresses should not sent and must be ignored on receipt?

## References

Expand Down