http: Removes section about http paths #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a multiaddr for `/http-path` so the section is now irrelevant
achingbrain
reviewed
Oct 8, 2024
| @@ -13,13 +13,13 @@ Interest Group: [@marcopolo], [@mxinden], [@marten-seemann] | |||
| [@marten-seemann]: https://github.com/marten-seemann | |||
|
|
|||
| ## Table of Contents <!-- omit in toc --> | |||
|
|
|||
| - [Context](#context) | |||
| - [What is an HTTP transport](#what-is-an-http-transport) | |||
| - [Multiaddr representation](#multiaddr-representation) | |||
| - [HTTP Paths (and other HTTP Semantics)](#http-paths-and-other-http-semantics) | |||
There was a problem hiding this comment.
This TOC line needs removing since the corresponding section has been removed, or you can regenerate it using Markdown All in One or similar.
achingbrain
reviewed
Oct 8, 2024
|
|
||
| Note: When we use `/quic-v1/http` or `/tcp/443/tls/http` (or any other | ||
| transport) implementations MUST use the correct HTTP ALPN (e.g. `h3` or `h2` | ||
| respectively) and not `libp2p` when using the HTTP transport. | ||
|
|
||
| ## HTTP Paths (and other HTTP Semantics) | ||
|
|
||
| It may be tempting to add an HTTP path to end of the multiaddr to specify some |
There was a problem hiding this comment.
I guess this means we do have paths in HTTP Multiaddrs now? Is it worth adding an example of their use?
sukunrt
approved these changes
Feb 24, 2025
|
|
||
| In general, it's better to keep the multiaddrs as a way of addressing an |
There was a problem hiding this comment.
lowercase is fine? It's lowercase everywhere.
| for the transports being used, and another multiaddr for the application-level | ||
| you may end up with many Multiaddrs with different transports but the same | ||
| suffix. A potential solution here is to keep them separate. A list of Multiaddrs | ||
| for the transports being used, and another Multiaddr for the application-level | ||
| data. This is one suggestion, and many other strategies would work as well. |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have them now.