Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:enable graphic string #79

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat:enable graphic string #79

merged 2 commits into from
Feb 4, 2025

Conversation

privatepatrick
Copy link
Contributor

@privatepatrick privatepatrick commented Jan 30, 2025 •
edited
Loading

Adds GraphicString support the ASN.1 compiler.

Graphic string support was added to rasn in this commit: librasn/rasn@d97c44d

@6d7a
Copy link
Member

6d7a commented Feb 4, 2025

Thank you for your contribution. Could I ask you to add some tests to simple_types in rasn-compiler-tests?

@privatepatrick
Copy link
Contributor Author

privatepatrick commented Feb 4, 2025 •
edited
Loading

Thank you for your contribution. Could I ask you to add some tests to simple_types in rasn-compiler-tests?

Copied the GeneralString tests. The distinction between general and graphic is a more constrained character set ,as well as a different Universal tag, which should be caught by the tests in the rasn repository.

4e1926b

@6d7a 6d7a merged commit 8a0ba36 into librasn:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6d7a 6d7a 6d7a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@privatepatrick @6d7a