Add gh action to upload artifacts #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
force-pushed
the
f/upload-artifacts
branch
2 times, most recently
from
94e7553 to
bcaa121
Compare
selankon
added
artifact
selankon
force-pushed
the
f/upload-artifacts
branch
from
a61c790 to
fc7ca98
Compare
selankon
added
artifact
selankon
force-pushed
the
f/upload-artifacts
branch
from
fc7ca98 to
eb6f1cd
Compare
selankon
added
artifact
selankon
force-pushed
the
develop
branch
12 times, most recently
from
e11390e to
c749df1
Compare
selankon
force-pushed
the
f/upload-artifacts
branch
from
4b6dcab to
cc4773f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTR
Limeapp automatic preview builds.
Now when a PR is marked with the Labels "artifact", an additional GH action will run to upload a built version of the limeapp on GH.
This artifact will store the PR number, to on posterior publish a GH comment on the PR with the artifacts url.
Example:
#398 (comment)
The github action to publish the comment runs on the develop branch and not on the pr to protect from external forks PR's the secrets and other configurations (to comment on the PR the action needs write and read permissions, which are dangerous to give to a fork from an external repository).
Further reading
Keeping your GitHub Actions and workflows secure
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
https://glasnt.com/blog/pull_request_target_labels/
Workflow run docs
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_run