Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually read CLI args in emscripten #17614

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Actually read CLI args in emscripten #17614

wants to merge 4 commits into from
+143 −70

Conversation

JoeOsborn
Copy link
Contributor

@JoeOsborn JoeOsborn commented Feb 21, 2025 •
edited
Loading

This PR does three things:

  1. Fix a bug related to the restructuring of the emscripten build's entry point. An args struct was allocated and passed, but never initialized properly.
  2. Fix fetch manifest feature for lazy piece-by-piece loading of large files
  3. Replace stdin/stdout command interface for WASMFS builds with new emscripten exec command driver that can easily be driven from JavaScript. This should allow us to eventually remove the cmd_* exported functions and is better from a thread safety standpoint.

@JoeOsborn JoeOsborn marked this pull request as draft February 21, 2025 20:02
@JoeOsborn
Copy link
Contributor Author

I want to roll this in with another fix to the fetch manifest feature for lazy file loading from remotes, so putting this in draft status for now.

@JoeOsborn
Fix fetchfs manifest parsing, increase download chunk size
8638ee6 
The chunk size should probably be made a parameter in the future.  The
larger chunk size trades longer hitches for fewer hitches.
@JoeOsborn
Add exec command driver and API functions for emscripten.
5e870ec 
Under WASMFS, stdin/stdout can't be customized the way they can with
the JS FS implementation.  Also, this approach frees up stdin/stdout
and simplifies interaction with the command interface for web embedders.
@JoeOsborn
fixup upload paths, show use of new emscripten cmd interface
fa50f7b
@JoeOsborn JoeOsborn marked this pull request as ready for review February 22, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoeOsborn