Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotools: set CMake libraries directly in configure.ac #656

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Jan 5, 2025

Build CMake list containing CMake targets in configure.ac

I tested this with:

mkdir build
cd build
../configure --prefix=$PWD/prefix --enable-music-mod-modplug-shared=no --enable-music-mod-xmp-shared=no --enable-music-midi-fluidsynth-shared=no --enable-music-gme-shared=no --enable-music-ogg-vorbis-shared=no --enable-music-ogg-tremor-shared=no --enable-music-flac-libflac-shared=no --enable-music-mp3-mpg123-shared=no --enable-music-opus-shared=no --enable-music-wavpack-shared=no
make
make install
cmake -S ../cmake/test -B /tmp/sdl2-mixer-autotools-cmake-test-build --fresh -DCMAKE_PREFIX_PATH=$PWD/prefix
cmake --build /tmp/sdl2-mixer-autotools-cmake-test-build

Fixes #655

@madebr madebr requested a review from sezero January 5, 2025 13:30
Copy link
Contributor

@sezero sezero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my aututools glasses only, looks good to me.

@sezero sezero merged commit 7e9ed83 into libsdl-org:SDL2 Jan 5, 2025
8 checks passed
@madebr madebr deleted the cmake-in-autotools-heresy branch January 5, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants